[ttLib/pyftmerge] Handle cmap merge better #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was trying to merge Emoji fonts so I could get some color emoji on my Windows 7 machine occasionally when I discovered that |
| class CmapMergeUnitTest(unittest.TestCase): | ||
| def setUp(self): | ||
| self.merger = Merger() | ||
| self.table1 = ttLib.getTableClass('cmap')('cmap') |
|
Thanks for this! I left a few minor comments. Please address those and I'll merge. |
Changed the merge algorithm to properly handle cmap subtables of type 4 and 12 with platform id and encoding ids of 3/1 and 3/10 respectively. All other subtables are not merged and ignored. The resulting merged cmap table includes a subtable of format 4/3/1 and a format 12 subtable iff there are mappings outside of the BMP. If one font has two codepoints that point to the same glyph, and another font has the same code points pointing to two other glyphs, keep the behavior where the first replacement glyph is stored in 'locl' and output the third glpyh (or more) to let the user know that they were dropped, instead of failing to merge the font. Fixes fonttools#444 Fixes fonttools#322
|
Amended my commit with your recommendations :) |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the merge algorithm to properly handle cmap subtables
of type 4 and 12 with platform id and encoding ids of 3/1 and 3/10
respectively. All other subtables are not merged and ignored.
The resulting merged cmap table includes a subtable of format 4/3/1
and a format 12 subtable iff there are mappings outside of the BMP.
If one font has two codepoints that point to the same glyph,
and another font has the same code points pointing to two other glyphs,
keep the behavior where the first replacement glyph is stored in 'locl'
and output the third glpyh (or more) to let the user know that they were
dropped, instead of failing to merge the font.
Fixes #444
Fixes #322