Returning errors + status from csharpier server. Make sure we don't hang the old stdout version when cli fails #1191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
belav
force-pushed
the
server-error-handling
branch
3 times, most recently
from
800e831 to
8135d1f
Compare
…stdout version when cli fails
belav
force-pushed
the
server-error-handling
branch
from
8135d1f to
a44ef14
Compare
belav
added a commit
that referenced
this pull request
Mar 9, 2024
belav
changed the title
belav
added a commit
that referenced
this pull request
Mar 12, 2024
belav
added a commit
that referenced
this pull request
Apr 12, 2024
belav
added a commit
that referenced
this pull request
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes the changes needed to have csharpier return errors using the server option.
And also fixes an issue with the stdout version causing hangs if it through an exception, it would never write out the "finished" character.