Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print checked the same way as an invocationExpression #329

Merged
merged 1 commit into from
Jun 22, 2021

Conversation

belav
Copy link
Owner

@belav belav commented Jun 20, 2021

closes #270

@belav belav force-pushed the checked-breaking branch from fe9ae3c to dba5a40 Compare June 20, 2021 17:18
Node.Print(node.Expression),
Token.Print(node.CloseParenToken)
Doc.Group(
Token.Print(node.OpenParenToken),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we maybe have a helper method for invocation expression like things?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a similar thought, but it was different enough from how parameters are printed for Invocations that I didn't think it made sense to try to combine them. I just looked around and there are a lot of SyntaxNodePrinters that print the same style for the parens, but they all seem different enough that it would be hard to share the logic. : /

@belav belav merged commit 1aa0881 into master Jun 22, 2021
@belav belav deleted the checked-breaking branch June 22, 2021 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Format checked like a invocation expression with an argument list
2 participants