ignore failOnDynamicVersions() to fetch latest versions #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ben-manes
reviewed
Mar 25, 2022
Comment on lines
44
to
46
| import org.gradle.api.internal.artifacts.configurations.DefaultConfiguration | ||
| import org.gradle.api.internal.artifacts.configurations.ResolutionStrategyInternal | ||
| import org.gradle.api.internal.artifacts.ivyservice.resolutionstrategy.DefaultResolutionStrategy |
There was a problem hiding this comment.
looks like you don't need these anymore?
ben-manes
approved these changes
Mar 25, 2022
|
Thanks! great idea and approach :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides a way to fetch the latest version despite having
resolutionStrategy.failOnDynamicVersions()active.Gradle does not expose an official way to disable this check once activated currently. The proposed solution relies on the implementation of the internal
DefaultResolutionStrategy, but is generally backwards compatible.resolves #592