Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Consolidate Markdown split levels #137

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Conversation

benbrandt
Copy link
Owner

In hindsight, these levels were a bit to granular, which led to some strange splitting behavior. More elements are consolidated into fewer levels to allow for much more natural split points.

Will be a breaking change in the output of the Markdown splitter.

In hindsight, these levels were a bit to granular, which led to some strange splitting behavior. More elements are consolidated into fewer levels to allow for much more natural split points.

Will be a breaking change in the output of the Markdown splitter.
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.72%. Comparing base (17bc95a) to head (88eae40).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #137      +/-   ##
==========================================
- Coverage   99.75%   99.72%   -0.03%     
==========================================
  Files           7        7              
  Lines        1603     1432     -171     
==========================================
- Hits         1599     1428     -171     
  Misses          4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benbrandt benbrandt merged commit 4eabfec into main Apr 5, 2024
23 checks passed
@benbrandt benbrandt deleted the markdown-levels branch April 5, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant