Iterative Approach #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #7 +/- ##
==========================================
- Coverage 97.59% 96.79% -0.81%
==========================================
Files 5 5
Lines 458 374 -84
==========================================
- Hits 447 362 -85
- Misses 11 12 +1
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As is always the case in Rust, the "elegant" recursive approach causes issues.
When building on top of this for Markdown Splitting, I ran into stack overflow issues, as well as compile time issues, which I think comes from lots of
impl Iteratorreturn types the compiler has to recursively figure out.Moving to an iterative approach with a custom impl Iterator for walking through the text str. And then can hopefully use a similar approach for walking through the Markdown events.