-
-
Notifications
You must be signed in to change notification settings - Fork 956
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Allow temp region selection from result view
This adds a new "temporary" config section of the results view, where a user can now change the country that their results come from without changing their default config settings. Closes #322
- Loading branch information
Showing
7 changed files
with
43 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3f363b0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you :)
3f363b0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a variable to disable this? I recently got this after updating my docker image, but would much rather keep a minimalist result view.
3f363b0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ariojas not yet. I'll work on either adding a variable to hide it or have it appear collapsed in the result view by default.
3f363b0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ariojas taken care of in a6a97aa. There's now a separate toggle to open/close the "advanced search" menu.
3f363b0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@benbusby Wow, thanks. That was a super quick turnaround. I've been meaning to ask, I run my whoogle instance via a docker container in unraid. I'm not sure how many inquiries you get regarding that OS, but I'd be happy to contribute what little knowledge I have of managing the docker instance in that UI (the GUI makes managing the docker easier, but unconventional via the usual instructions).
3f363b0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is this toggle? On the latest version there is no way to select a temporary country. It looks exactly the same as before you implemented the change. The other issue where the option was available to temporarily change the country I would select 'UK' and nothing happened to the results - no refresh, no localised results, nothing. Have I missed a step in the process?
3f363b0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a bug with the previous implementation where nothing would happen when selecting the country (which has been fixed).
The toggle is in the tab bar on the results page, it should be a unicode gear icon.
TOGGLE CLOSED
TOGGLE OPEN
COUNTRY SELECTED