Skip to content

Commit

Permalink
Set max height for config menu
Browse files Browse the repository at this point in the history
The config menu has gotten out of control recently, but rather than
reducing functionality, I'm just going to set a max height for the div
and allow scrolling within the menu.

Ultimately though this indicates that the app is getting a bit too
complicated (imo). Striking a balance between customization and
minimalism is less of a priority for me nowadays though, hence why I'm
willing to let it slide for now. At some point, maybe when there are
more contributors, it could be nice to refactor this in some way so that
it isn't overwhelming to new users who are looking to customize their
instance (that's just me speculating btw, I haven't actually heard from
anyone who thinks there are too many options in that menu).
  • Loading branch information
benbusby committed Nov 1, 2021
1 parent c766554 commit b73c14c
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 2 deletions.
1 change: 1 addition & 0 deletions app/static/css/main.css
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ button::-moz-focus-inner {
}

.open {
overflow-y: scroll;
padding-bottom: 20px;
}

Expand Down
2 changes: 1 addition & 1 deletion app/static/js/controller.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ const setupConfigLayout = () => {
if (content.style.maxHeight) {
content.style.maxHeight = null;
} else {
content.style.maxHeight = content.scrollHeight + "px";
content.style.maxHeight = "400px";
}

content.classList.toggle("open");
Expand Down
3 changes: 2 additions & 1 deletion app/templates/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,10 @@
}

.content {
max-height: 720px;
max-height: 400px;
padding: 18px;
border-radius: 10px;
overflow-y: scroll;
}

.collapsible {
Expand Down

0 comments on commit b73c14c

Please sign in to comment.