Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Broken site alts for some urls due to bad skip_prefix logic #1091

Closed
6 tasks
kageiit opened this issue Oct 25, 2023 · 0 comments · Fixed by #1092
Closed
6 tasks

[BUG] Broken site alts for some urls due to bad skip_prefix logic #1091

kageiit opened this issue Oct 25, 2023 · 0 comments · Fixed by #1092
Labels
bug Something isn't working

Comments

@kageiit
Copy link
Contributor

kageiit commented Oct 25, 2023

Describe the bug
When using site_alts with certain patterns like for eg: "endswithm.net" , the replaced url is incorrect. for eg: reddit links are replaced with "endswith//net" instead of "endswithm.net"

To Reproduce
Steps to reproduce the behavior:

  1. Set WHOOGLE_ALT_RD=endswithm.net
  2. Do a search for reddit topics
  3. See broken alt urls

Deployment Method

  • Heroku (one-click deploy)
  • [ x] Docker
  • run executable
  • pip/pipx
  • Other: [describe setup]

Version of Whoogle Search

  • [ x] Latest build from [source] (i.e. GitHub, Docker Hub, pip, etc)
  • Version [version number]
  • Not sure

Desktop (please complete the following information):

  • OS: Windows
  • Browser : chrome
  • Version: 118.0.5993.89
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: correctly handle skip_prefix logic for site_alts kageiit/whoogle-search
1 participant
@kageiit