Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to extract query on error condition and print trace #1131

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

pantherman594
Copy link
Contributor

When an error is hit, the search alternatives are not useful because the query is still encrypted. This PR tries to decrypt the search query for the error page. It also prints a stack trace of the exception for easier debugging.

@pantherman594
Copy link
Contributor Author

I originally included the query with the stack trace to potentially help with debugging, but I realized logging these queries could be a privacy concern. Let me know if you think that would be useful to add back

Copy link
Owner

@benbusby benbusby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, agreed about not logging queries in the traceback

@benbusby benbusby merged commit 80e41e6 into benbusby:main Apr 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants