Implement scribe.rip replacement for medium.com #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbusby
approved these changes
Oct 16, 2021
There was a problem hiding this comment.
Sweet, this is working great. Definitely a nice feature to have.
I made a quick commit to fix some super minor PEP-8 formatting issues, and moved the hostname variable declaration out of the for loop in get_site_alt. I realized it only actually needs to be declared once -- my initial example I gave for implementation overlooked that, so that's my bad.
Thanks for tackling this issue so quickly!
benbusby
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have implemented the feature #455.
scribe.rip an alternative to medium.com