Allow setting Accept-Language header #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @vacom13! No need to apologize for any delays, there's no impending deadline for the next release or anything. I'm just happy you're helping out! I'll try to review later today or possibly tomorrow. I'm in the middle of moving, so my time for this stuff is a bit sporadic. |
|
@benbusby oh great. Happy to help! |
benbusby
approved these changes
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have given like an option whether the user wants to send it as an accept language header. However I am not sure if this is what you had in mind when talking about this feature. So do tell me if I should instead do something else.
P.S Sorry for the delay, just fell ill.
Implements #445