Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Update Available warning #517

Merged
merged 3 commits into from
Nov 2, 2021
Merged

Add Update Available warning #517

merged 3 commits into from
Nov 2, 2021

Conversation

vacom13
Copy link
Contributor

@vacom13 vacom13 commented Nov 1, 2021

Update available now shows up in the footer if "version_number" doesn't match the newest version.
Implements #305

Copy link
Owner

@benbusby benbusby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vacom13, great work. A few small adjustments to make, then this should be good to merge.

app/routes.py Outdated Show resolved Hide resolved
app/routes.py Outdated Show resolved Hide resolved
app/templates/footer.html Outdated Show resolved Hide resolved
app/templates/footer.html Outdated Show resolved Hide resolved
@benbusby benbusby linked an issue Nov 1, 2021 that may be closed by this pull request
@vacom13
Copy link
Contributor Author

vacom13 commented Nov 2, 2021

Okay. I will work on it.

Copy link
Owner

@benbusby benbusby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, looks good. Thanks again!

@benbusby benbusby merged commit 3784d89 into benbusby:main Nov 2, 2021
@vacom13
Copy link
Contributor Author

vacom13 commented Nov 2, 2021

@benbusby I want to level up helping 😅. For now, been doing uk beginner level stuff. Well I am a newbie but I want to learn so how else can I contribute or are there resources u could refer to me?

@benbusby
Copy link
Owner

benbusby commented Nov 2, 2021

@vacom13 the work you've been doing has been great, and super helpful, even if it might feel like beginner level stuff. If you want to contribute more, you can always look through the available issues and just start picking any that sound interesting to you. There's a few items that come to mind that might be a bit more difficult, but would definitely be well received by users I think, such as:

  • Allow defining a list of proxy connections instead of just one, and cycling through them if any are blocked by Captcha
    • See [FEATURE] Multiple Proxies #383 (would need to factor in both latency and availability -- low latency but blocked by Captcha proxies would need to be skipped)
    • Would also need to ensure that this doesn't hinder app performance too much.
  • Adding "nice to have" features to the results view. These all require some sort of integration with an external service, so you'd need to be careful with how you're implementing it. Things like ratelimiting would need to be investigated prior to implementation.
    • Show hours for a business if that's the first result (see [FEATURE] Add "hours" ranges to Place result #301)
    • Implement a more full featured currency conversion (see [FEATURE] Currency conversion #129) -- this one is closed, but I'd be willing to re-open if there's a straightforward way to implement without requiring a third party JS library or something like that. Ideally it would be a new endpoint within Whoogle for converting currency, with a regex to detect if the search is related to currency. I'm thinking /convert?from=usd&to=gbp&amount=1.99, with a really simple UI embedded as the first result, similar to what you did for the "My IP" card

I can try thinking of other things, but it depends on what your interests are. Like I said, I'm happy to assign any of the available issues to you. You're doing great with contributing so far, it's been nice having someone else around to help clear out the backlog of issues 😄

@benbusby
Copy link
Owner

benbusby commented Nov 2, 2021

You could also look into deploying to other services that users have requested in the past, seen here: #62

Those might feel a bit too simple, but provide a lot of value for people who have preferred deployment environments that aren't being addressed. One of the core benefits of Whoogle (imo) is the ease of deployment, so the more support for other deployment options, the better.

@vacom13
Copy link
Contributor Author

vacom13 commented Nov 4, 2021

Okay. Great. I will just look into the issues then and try to figure stuff out on the go I guess. For now, I have been busy with a couple of things, will look at them asap @benbusby.

@vacom13
Copy link
Contributor Author

vacom13 commented Nov 5, 2021

@benbusby I was thinking of maybe giving the implementation of the full currency conversion a try. Something like what google does right? I can use like my own javascript tho right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Update available warning
2 participants