Return 401 when token is invalid #714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdm85
force-pushed
the
fix/invalid-token-401
branch
from
f432494 to
992817c
Compare
gdm85
force-pushed
the
fix/invalid-token-401
branch
from
992817c to
41b9e4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some rare instances (a race condition perhaps?) a
cryptography.fernet.InvalidTokenexception is thrown resulting into a broken connection.This change gracefully returns a 401 error instead.
NOTE: it might be desirable to do some logging as well if the client is induced into this error because of a bug on server side