Use X-Forwarded-Host as url_root when present #799
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If whoogle is behind a proxy which is accessed on a non-standard port, this port is lost to the application and
element['src']
s are incorrectly formed (omitting port). The port is also missing when redirecting after new session.E.g. some unrelated service is running on example.com:80/443 and Nginx listens on example.com:5000 proxying to whoogle which listens on some host 5001. In this case,
request.url_root
doesn't include the front port 5000 which is expected by the client (browser) to renderimg.src
correctly.HTTP X-Forwarded-Host will contain this front port number in a typical Nginx reverse proxy configuratoin, e.g.