Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UMD build & transform cookie CJS build into ESM for ESM build #460

Merged
merged 6 commits into from
Feb 20, 2024

Conversation

eXon
Copy link
Collaborator

@eXon eXon commented Feb 16, 2024

  • The UMD build was crashing because the cookie library is not UMD compatible. This will make sure it gets bundled correctly.
  • The cookie library is not ESM compatible until Add ESM build script jshttp/cookie#154 is merged. For now, we will transform the library into ESM within our build process instead of importing something incompatible.

@eXon eXon merged commit 8233e19 into main Feb 20, 2024
3 checks passed
@eXon eXon deleted the bugfix/fix-esm-umd branch February 20, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant