Exit with an error if --gil but we failed to get necessary addrs/offsets #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we'd just emit a warning, which is less noticeable; and the result of a --gil run where without the needed information is going to empty, anyway.
Merged
benfred
reviewed
Mar 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we'd just emit a warning, which is less noticeable; and the result of
a --gil run where without the needed information is going to empty, anyway.
I think it's better, user-experience wise (like mentioned in #358 (comment)). Well at least I can vouch for it personally, I'm quite annoyed by
--gilrecordings producing empty stack files / graphs, it always takes me a short while to recall the possibility that it is simply unsupported...About the positioning of the check - might've been nicer to place this code in
main.rs, but it's much easier if the exit decision is made next to the failure itself. I can try moving it if you think that's better.