Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vertical placement of top elements in the Manager window #520

Closed
benfry opened this issue Jul 31, 2022 · 4 comments
Closed

Fix vertical placement of top elements in the Manager window #520

benfry opened this issue Jul 31, 2022 · 4 comments
Labels
Help Wanted We have very little time and would like some help

Comments

@benfry
Copy link
Owner

benfry commented Jul 31, 2022

Too much space below the search field, should be the same as above the field. The space above may need to be a pixel or two higher:

screenshot

The upper area is also larger for the “Libraries” tab, presumably because of the vertical height of the dropdown. But that needs to be fixed (maybe the drop down has extra space that needs to be removed?) so the UI doesn't jiggle as you move between tabs.

@benfry benfry added Help Wanted We have very little time and would like some help good first issue labels Jul 31, 2022
@benfry
Copy link
Owner Author

benfry commented Jul 31, 2022

LesleyWagner added a commit to LesleyWagner/processing4 that referenced this issue Aug 20, 2022
@LesleyWagner
Copy link
Contributor

I made a pull request for this issue #539. Here is a screen capture of the solution https://user-images.githubusercontent.com/33584486/185764011-82daad14-0f60-4500-9ae0-de824df54847.mp4
Let me know if anything must be changed.

P.S. This is my first pull request on an open source project.

@benfry
Copy link
Owner Author

benfry commented Aug 20, 2022

Awesome! Nice work. Now integrated for 4.0.2; thanks for looking into it!

@benfry benfry closed this as completed Aug 20, 2022
@github-actions
Copy link

This issue has been automatically locked. To avoid confusion with reports that have already been resolved, closed issues are automatically locked 30 days after the last comment. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Help Wanted We have very little time and would like some help
Projects
None yet
Development

No branches or pull requests

2 participants