Full line edt #772
Merged
Full line edt #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good; thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We got pretty close on #752. However, the EDT often will place errors in unexpected places and with a width of 1 character (gives us a point where there was a problem but not the correct number of characters involved). This does not impact ANTLR issues.
I believe that, previous to the efforts to improve error highlighting, earlier versions of Processing 4 were highlighting the whole line but stuff related to #752 and #715 tried to make this more precise. This PR restores that earlier behavior and formalizes the interface. See attached.
Note that this does not impact upsteram errors in the build pipeline, only things that get through to the EDT. It also does not change behavior for errors reported at compile or runtime using javac directly.