Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #825 - Showing wrong errors' line numbers for .java files #826

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

e1dem
Copy link

@e1dem e1dem commented Mar 13, 2024

Fix for bug #825.

Using PreprocSketch.mapJavaToSketch result for processing .java files is incorrect, as a sketch's combined source code file does not include code from .java tabs.

As far as I can see, there is a similar issue with showing variables usage, so I would suggest this solution as a temporary one.

@e1dem e1dem marked this pull request as ready for review March 13, 2024 10:44
@hkiel
Copy link
Contributor

hkiel commented Jun 8, 2024

@benfry Is this PR going to be incorporated at any time soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants