Warn users or provide auto-fix when frame is used in a sketch
#99
Conversation
| final String undefinedName = args[0]; | ||
| if (undefinedName.equals("frame")) { | ||
| result = Language.interpolate("editor.status.item_removed", undefinedName, "surface"); | ||
| } |
There was a problem hiding this comment.
Minor request... I think we have been doing } else {
| @@ -1310,6 +1310,12 @@ static public void showChanges() { | |||
| } | |||
| } | |||
|
|
|||
| static public void showChangesV4() { | |||
There was a problem hiding this comment.
Thank you so much for this @urbanskimichal! What are your thoughts on replacing showChanges outright?
There was a problem hiding this comment.
Actually how about doing a showChangesV3 and showChangesV4 (same for handleCrustyCode). See urbanskimichal#2.
|
I made the above changes ahead of an integration branch build. It's ok if we go a different direction. See urbanskimichal#2. Thank you again @urbanskimichal! |
|
This is available on an integration branch at https://github.com/sampottinger/processing4 ( |
Work done:
frameoccurs during compilation.Changes in 4.0document.For now I don't think I'm ready for the auto-fix, but can think about it in the future.
This is my first contribution so I'm waiting for suggestions or opinions.