workaround missing dictproxy methods Fixes #295 #296
Conversation
| viewkeys = operator.methodcaller("viewkeys") | ||
| def viewkeys(d): | ||
| if isinstance(d, types.DictProxyType): | ||
| d = dict(d) |
There was a problem hiding this comment.
this should actually return collections.abc.KeysView etc
There was a problem hiding this comment.
@benjaminp thoughts?
|
Thank for your the PR. To fix this properly, you would have to actual provide a view that was updated if the underlying dictionary was updated. Since you weren't able to view dict proxies on Python 2 anyway, I don't think this needs to be fixed, though. |
|
collections.abc.KeysView does update and the unmoved collections.KeysView updates too |
correct, but this PR does not implement that behavior for dict proxies. |
|
@benjaminp, sure but I don't know how best to import collections.abc for every python version |
|
Yes, this all leads to my feeling that the complexity of fixing this correctly is not worth it. |
|
@benjaminp now that #155 has landed, how do I go about using it in six? |
No description provided.