Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show known components in populate help #33

Closed
iainelder opened this issue May 22, 2021 · 6 comments
Closed

Show known components in populate help #33

iainelder opened this issue May 22, 2021 · 6 comments

Comments

@iainelder
Copy link

Would it be possible to show the known components in the online help for aws-sso-util configure populate?

I was trying to find a way to remove the role name from the generated profile names. In my environment I have the same single role available in all the accounts, so its name is redundant.

The online help hints that it is possible to control the elements of the profile name, but doesn't give any detail about what the valid components are.

  --components VALUE,VALUE,...    Profile name components to join (comma-
                                  separated)

I had to refer to the code on Github to get the answer (--components account_name).

KNOWN_COMPONENTS = [
"account_name",
"account_id",
"account_number",
"role_name",
"region",
"short_region",
]

Would it be possible to include the known components in the online help to make the command easier to use?

@benkehoe
Copy link
Owner

If I understand correctly, you're saying you want them in the help output by the command, that the docs here are not enough? That seems reasonable, I can put it in there for the next release. I'll leave this issue open until it's done.

@iainelder
Copy link
Author

Hi, @benkehoe, thanks for the link to the documentation. I had missed that page on first reading before diving in.

Now that I've seen that, I would be happy to close this without any changes. I had mistakenly thought the values were undocumented.

Thanks so much for this tool in any case. It makes working with AWS SSO a more friendly experience.

@benkehoe
Copy link
Owner

benkehoe commented Jun 2, 2021

It makes sense to have the list of values in the command-line help as well, even if it's not explained as thoroughly as in the docs.

@benkehoe
Copy link
Owner

This is released in CLI v4.26

@iainelder
Copy link
Author

The output of aws-sso-util configure populate --help now shows:

  --components VALUE,VALUE,...    Profile name components to join (comma-
                                  separated). Possible values are:
                                  account_name account_id account_number
                                  role_name region short_region

Just as I had imagined it. This is functions as a memory aid, and the documentation provides a space for a detailed analysis.

It seems like a small improvement, but it means a lot. The structure of your Github projects and your writing about boto3 programming have inspired me to maintain my own set of AWS utilities written in Python.

Keep up the good work :-)

@benkehoe
Copy link
Owner

Sorry it took so long for a release to come out to ship it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants