Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give go code it's own package directory #17

Merged
merged 2 commits into from
Jun 14, 2016

Conversation

gdbelvin
Copy link
Contributor

Makes the go code available via
go get github.com/benlaurie/objecthash/go/objecthash

  • Package path conforms to standard Go conventions. I.e. the directory and
    the package name should match.
  • Resolves an issue where the go compiler was attempting to build the C
    files by giving the go code it's own directory.
  • Cleans up the FIXME comments

gdbelvin added 2 commits June 10, 2016 15:24
Makes the go code available via
`go get github.com/benlaurie/objecthash/go/objecthash`
- Package path conforms to standard Go conventions.  I.e. the directory and
  the package name should match.
- Resolves an issue where the go compiler was attempting to build the C
  files by giving the go code it's own directory.
var buf bytes.Buffer
buf.WriteString(t)
buf.Write(b)
return sha256.Sum256(buf.Bytes())
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. :-)

@benlaurie benlaurie merged commit 4a8a439 into benlaurie:master Jun 14, 2016
@gdbelvin gdbelvin deleted the cleanup branch June 14, 2016 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants