Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSTOR's new .zip format for DfR results breaks package syntax #34

Open
felixhaass opened this issue Dec 3, 2017 · 5 comments
Open

JSTOR's new .zip format for DfR results breaks package syntax #34

felixhaass opened this issue Dec 3, 2017 · 5 comments

Comments

@felixhaass
Copy link

Hi there,

first of all, let me thank you for the JSTORr package which sounds like an extremely useful piece of software. Thanks for the work in putting this together!

When trying the package this morning, however, the basic command fails (where the working directory is the unzipped received .zip file):

unpack1grams <- JSTOR_unpack1grams()

It seems like JSTOR has changed the contents of the .zip file it generates, since no citations.tsv file is generated, either, but a bunch of xml files instead. Here's a sample .zip file to reproduce the error.

Best,
Felix

@benmarwick
Copy link
Owner

Thanks for letting me know, this happens from time to time, they change their output format with no warning or news. I will take a look!

@BillyHall5
Copy link

BillyHall5 commented Mar 10, 2018

Ben,
Like felixhaass I'm super excited by your JSTORr package. It is perfect for what I need to do with journal data. But like him I'm also having difficulty now that JSTOR has changed the format of the files it delivers. I tried to mimic the files by converting the xml metadata to citatiouns tsv and the ngram1 txt files to wordcount csv files. But no luck same error with the basic command:

unpack1grams <- JSTOR_unpack1grams("path = . . .)

The error i get is:

Error in setwd(paste0(path, "/wordcounts")) :
cannot change working directory

Can you suggest any work arounds? I'm very much a beginner with programming, but I've got lots of help when the will gives out.
Thanks again for this really powerful tool.

All the best,
Billy

@benmarwick
Copy link
Owner

Thanks for the reminder about this issue, I'll take a look.

In the meantime, you may find this pkg useful: https://github.com/tklebel/jstor

@BillyHall5
Copy link

BillyHall5 commented Mar 11, 2018 via email

@brycehansche
Copy link

Ben,
Thank you for making this tool, and for the suggestion for the additional tool! I was just wondering if there was any update on this current issue.
-Bryce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants