Move setting of environmental variables (configured via the raw_env sett... #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tshlabs can you split the .gitignore change in a single commit? Other changes are ok. |
|
@benoitc Sure, will do. |
|
Looks fine to me, unless @benoitc, did you mean you wanted this squashed/amended to remove the .gitignore? |
Move setting of env vars from Arbiter.start to Arbiter.setup so that they are available during application start up when 'preload_app' is used. Closes #735
|
Squashed the changes into a single commit that doesn't include any modifications to .gitignore. |
tilgovi
added a commit
that referenced
this pull request
May 13, 2014
Move setting of environmental variables (configured via the raw_env sett...
|
💨 |
|
Thanks guys! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...ing) from Arbiter.start to Arbiter.setup so that they are available during application start up when 'preload_app' is used.
I didn't update any of the documentation related to these changes since I didn't really see a place where it would fit in very well. Please let me know if you'd like me to update some part of the docs.
Additionally, the unit test makes use of other parts of Gunicorn (BaseApplication), not just the Arbiter. I wasn't sure if that's OK or not, let me know if it needs to be reworked. Thanks.
Closes #735