Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP and HTTPS proxies might differ #734

Merged
merged 2 commits into from
Feb 21, 2024
Merged

Conversation

Juliusan
Copy link
Contributor

Hackney handle HTTP_PROXY and HTTPS_PROXY variables as they define the same thing. In fact (e.g. curl documentation) HTTP_PROXY should be used only for http requests and HTTPS_PROXY should be used only for https requests. This PR fixes that.
Moreover, this PR adds ALL_PROXY environment variable handling.

@benoitc benoitc merged commit 7ae3831 into benoitc:master Feb 21, 2024
5 checks passed
@benoitc
Copy link
Owner

benoitc commented Feb 21, 2024

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants