New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional check for horizontal scroll compatability #2

Open

homerjam wants to merge 1 commit into benpickles:master from homerjam:master

homerjam commented Jun 26, 2013

No description provided.


          Additionally check if element is within viewport width

da1141f

Owner

benpickles commented Jun 27, 2013

Hey that's great, I hadn't even thought of horizontal positioning!

I haven't had a chance to test this out yet but I have a few requests for the commit (sorry):

Don't bother generating the minified version, I'll do that when it's released.
Ditto for updating the version number.
Try not to reformat the whole document(!): it's changed from 2 spaces to 4; semicolons have been added to the end of lines; the preceding semicolon has disappeared; there's no longer a newline at the end of the file.

Otherwise, thanks for taking the time to put the pull request together 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet