Use activerecord-has_some_of_many (#263)

Gemfile

@@ -5,6 +5,7 @@ ruby File.read(File.join(File.dirname(__FILE__), '.ruby-version')).strip
 git_source(:github) { |repo| "https://github.com/#{repo}.git" }
 
 gem 'activerecord-explain-analyze'
+gem 'activerecord-has_some_of_many', github: 'bensheldon/activerecord-has_some_of_many', branch: 'main'
 gem 'activerecord-postgis-adapter'
 gem 'autoprefixer-rails'
 gem 'aws-sdk-s3'

Gemfile.lock

@@ -1,3 +1,11 @@
+GIT
+  remote: https://github.com/bensheldon/activerecord-has_some_of_many.git
+  revision: 6e0fec013f760ef6b2408b3b18bdc161a3ddef87
+  branch: main
+  specs:
+    activerecord-has_some_of_many (1.0.0)
+      rails (>= 7.0.0.alpha)
+
 GIT
   remote: https://github.com/bensheldon/open311.git
   revision: dbead4703063d070fa3615fc371d352e3a312ee2
@@ -493,6 +501,7 @@ PLATFORMS
 
 DEPENDENCIES
   activerecord-explain-analyze
+  activerecord-has_some_of_many!
   activerecord-postgis-adapter
   annotate
   autoprefixer-rails

app/models/city.rb

@@ -22,8 +22,8 @@ class City < ApplicationRecord
   has_many :service_definitions
   has_many :statuses
 
-  has_one :service_list_status, -> { latest_by_city(:service_list) }, class_name: 'Status', inverse_of: :city
-  has_one :service_requests_status, -> { latest_by_city(:service_requests) }, class_name: 'Status', inverse_of: :city
+  has_one_of_many :service_list_status, -> { service_list.order(created_at: :desc) }, class_name: 'Status', inverse_of: :city
+  has_one_of_many :service_requests_status, -> { service_requests.order(created_at: :desc) }, class_name: 'Status', inverse_of: :city
   has_many :service_list_statuses, -> { service_list }, class_name: 'Status', inverse_of: :city
   has_many :service_requests_statuses, -> { service_requests }, class_name: 'Status', inverse_of: :city
   has_many :service_list_status_errors, lambda {

app/models/status.rb

@@ -25,29 +25,6 @@
 class Status < ApplicationRecord
   belongs_to :city
 
-  scope :latest_by_city, lambda { |request_name, count: 1|
-    # This scope is complex. The table_reference (which is `cities`) is aliased to be
-    # the model's table (`statuses`) so that when this scope is used as in an association
-    # the eagerloaded foreign key query (`WHERE statuses.city_id` IN ...) will work properly.
-    #
-    # SELECT <columns>
-    # FROM <table reference>
-    #      JOIN LATERAL <subquery>
-    #      ON TRUE;
-    #
-    query = select('subquery.*').from('(SELECT *, id AS city_id FROM cities) AS statuses')
-
-    join_sql = <<~SQL.squish
-      JOIN LATERAL (
-        SELECT * FROM statuses AS sub_statuses
-        WHERE sub_statuses.city_id = statuses.city_id
-          AND sub_statuses.request_name = :request_name
-        ORDER BY created_at DESC LIMIT :count
-      ) AS subquery ON TRUE
-    SQL
-
-    query.joins(sanitize_sql_array([join_sql, { request_name:, count: }]))
-  }
   scope :service_list, -> { where(request_name: 'service_list') }
   scope :service_requests, -> { where(request_name: 'service_requests') }
   scope :errored, -> { where(http_code: 400..) }