Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention the realm when logging that someone has started a new quest #122

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

neilb
Copy link

@neilb neilb commented Jul 13, 2013

Instead of saying:

Fred has started a new quest.

Say:

Fred has started a new chaos quest.

I haven't actually tested that this works, but it looks right from look at examples in your templates ;-)

@neilb
Copy link
Author

neilb commented Jul 13, 2013

I didn't put the tag classes on the link, but having a tag in the middle of a sentence might look goofy, but you could try it, I guess ...

@berekuk
Copy link
Owner

berekuk commented Jul 13, 2013

Hmm. Realm name is already there in right-bottom corner, but it's too far away.
I think I like this change, but what about other event types? Should "neilb commented on neilb's quest" become "neilb commented on neilb's perl quest"?

@bessarabov
Copy link
Collaborator

I think that insted of "neilb commented on neilb's quest" there should be "neilb commented on his own quest" (do we need to know the sex of the person to correctly say that?).

@neilb
Copy link
Author

neilb commented Jul 13, 2013

@bessarabov: agreed, scans much better with "his quest", but you need to know gender. For work I've been wanting to add gender for a while, for exactly this reason. It's all these sorts of little touches that add to the overall effect of a good UI.

@berekuk: yes, I thought it was too far away. I nearly added realm name to some of the others, but thought I should wait and see your reaction :-)

@neilb
Copy link
Author

neilb commented Jul 13, 2013

Now I'm wondering if it would read better as:

berassabarov added a quest in the chaos realm

rather than

berassabarov added a chaos quest

The latter scans fine for the current realm names, but might not for future unthought-of realm names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants