Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor pyodide/transcrypt template files to inherit from base ones #188

Open
3 tasks
berinhard opened this issue Oct 21, 2021 · 0 comments
Open
3 tasks

Comments

@berinhard
Copy link
Owner

The templates files listed under pyp5js/templates/transcrypt and pyp5js/templates/pyodide are very similar. The similar files are:

  • base_sketch.py.template - after Remove from pyp5js import *  #183 mege, transcrypt version is identical to pyodide's one.
  • index.html - are very similar, with minor differences. Probably a simple base.html with some blocks can do the trick here.
  • target_sketch.js.template / target.py.template - this is the mos complicated one. It requires a refactoring on Transcrypt mode to have all of it functionalities within target file. That way we'll probably be able to have a base_target.py with all the duplicated code to bind p5.js under pyodide/transcrypt mode
@berinhard berinhard added this to the pyp5js 1.0.0 milestone Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant