Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove from pyp5js import * #183

Merged
merged 4 commits into from
Oct 14, 2021
Merged

Conversation

berinhard
Copy link
Owner

Fixes #176

This PR updates the target.js from transcrypt backend to directly use the sketch content instead of importing it and, thus, forcing the from pyp5js import *.

This was achieved by changing the target python code to use the sketch content instead of the sketch name. The strategy is very similar to what we've done with Pyodide mode as well.
@berinhard berinhard merged commit e3e0bda into develop Oct 14, 2021
@berinhard berinhard deleted the feature/do-not-require-import branch October 14, 2021 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removal of import pyp5js from transcrypt sketches
1 participant