Make code editor collapsible #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changes some of the html/css in view_sketch to add a new button to collapse the code editor
berinhard
requested changes
Oct 15, 2021
There was a problem hiding this comment.
@jvfe the usability of the button is great and I'm ok on merging this PR. But when I tested it locally, it seems I'm getting an encoding error with something:
I think this is the only blocker with this PR. Again, thanks for your contribution.
Seems to cause encoding errors in some systems.
Oh, that's unfortunate hahah. I tried inserting a UTF-8 arrow in the button and didn't foresee that it would be a problem. |
berinhard
approved these changes
Oct 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to change around some of the preexisting HTML and CSS so the page would better support the changes I was introducing without breaking the current layout, but as far as I've seen it hasn't broken anything.