Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set utf-8 encoding for every open call #193

Merged
merged 3 commits into from
Nov 2, 2021
Merged

Conversation

berinhard
Copy link
Owner

Fixes #190

@berinhard berinhard marked this pull request as draft October 31, 2021 16:35
@berinhard berinhard force-pushed the bugfix/utf-8-encoding branch from e052133 to 7e7fd7b Compare November 1, 2021 20:38
@berinhard
Copy link
Owner Author

berinhard commented Nov 1, 2021

Hey @imlimws, maybe this PR can fix the issue you've ran. Since I don't know how to change my system's global encoding to use the same as yours (cp949), can you try to use this branch's pyp5js version and not the one from Pypi and check if the fix works? Feel free to add comments with any other eventual encoding problem you face.

To replace your pyp5js installation, please run:

# depending on how you've installed it first, you may need to use sudo to both uninstall and install
$ pip uninstall pyp5js 
$ pip install git+https://github.com/berinhard/pyp5js.git@bugfix/utf-8-encoding

Thanks,

@berinhard berinhard marked this pull request as ready for review November 1, 2021 20:42
@berinhard berinhard changed the title Set utf-8 encoding for all files open's calls Set utf-8 encoding for every open call Nov 1, 2021
@berinhard berinhard merged commit 3fc1b36 into develop Nov 2, 2021
@berinhard berinhard deleted the bugfix/utf-8-encoding branch November 2, 2021 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UnicodeEncodeError
1 participant