Stop overwriting preload function #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes both pyodide and transcrypt modes so the preload() function can work as intended.
berinhard
approved these changes
Nov 2, 2021
There was a problem hiding this comment.
Thanks a lot for such fast PR @jvfe 🍾 🍾 🍾
The code looks good but the only think I'll ask for is an update in the CHANGELOG.md linking to this PR (examples here).
|
And once I merge this, I'll release 0.7.1 with this and the other bugfixes |
I always forget to update the changelog, sorry. Done, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used the first code snippet in the issue to test it, seems to be working fine and as intended in both transcrypt and pyodide modes.