Make formatters object-oriented so we can Autoload them #1020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sethvargo this needs to be rebased |
This commit changes the way we handle formatter objects by using `const_get` instead of searching through a list of Formatter objects. This allows us to use Ruby's native `Kernel.autolaod` to _only_ load the formatter classes that we want. Switching to an object-orientated approach also makes it much easier to test and reason about the code. If anything, it is now less lines of code and less intimidating to a non-Rubyist.
|
@reset rebased and this is now 💚 |
reset
added a commit
that referenced
this pull request
Feb 22, 2014
Make formatters object-oriented so we can Autoload them
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the way we handle formatter objects by using
const_getinstead of searching through a list of Formatter objects. This allows us to use Ruby's nativeKernel.autolaodto only loadthe formatter classes that we want.
Switching to an object-orientated approach also makes it much easier to test and reason about the code. If anything, it is now less lines of code and less intimidating to a non-Rubyist.