Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loosen constraint on Thor #1107

Merged
merged 1 commit into from
Apr 7, 2014
Merged

Loosen constraint on Thor #1107

merged 1 commit into from
Apr 7, 2014

Conversation

reset
Copy link
Contributor

@reset reset commented Apr 7, 2014

We're locked to 0.18 and should loosen our constraint before releasing Berks 3.0

@reset reset added this to the 3.0.0 milestone Apr 7, 2014
@sethvargo
Copy link
Contributor

Why? What does 0.19 have that we don't get in 0.18? ~> 0.18 will pick up 19 if it is available and solves the graph. I don't see a reason to force an upgrade unless there's a security vulnerability or we are using an API that only exists in 19.

@reset
Copy link
Contributor Author

reset commented Apr 7, 2014

@sethvargo I worded the issue wrong. We're locked to 0.18 and we should loosen the constraint.

@reset reset changed the title Update to Thor 0.19 Loosen constraint on Thor Apr 7, 2014
reset added a commit that referenced this pull request Apr 7, 2014
@reset
Merge pull request #1107 from berkshelf/support-thor-19
35ae8ee 
Loosen constraint on Thor
@reset reset merged commit 35ae8ee into master Apr 7, 2014
@reset reset deleted the support-thor-19 branch April 7, 2014 00:57
@sethvargo
Copy link
Contributor

👍

@sethvargo sethvargo mentioned this pull request Apr 7, 2014
Closed
@berkshelf berkshelf locked and limited conversation to collaborators Jun 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reset @sethvargo