Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow redirects when we try to get a cookbook #1258

Merged
merged 2 commits into from
Jul 11, 2014

Conversation

jujugrrr
Copy link
Contributor

This is addressing issue #1257.
http://supermarket.getchef.com returns a redirect which is not currently supported.

Patch submitted by @hirose31

@obazoud
Copy link

obazoud commented Jul 11, 2014

Patch works fine here.

@mikesimons
Copy link

👍 works for us too

@edbo
Copy link

edbo commented Jul 11, 2014

Yeah this fixed both issues I was having with the berks and vagrant commands although I had to patch the gems in two places.

@jujugrrr
Copy link
Contributor Author

Thanks @mriddle for the specs 😉

@mriddle
Copy link
Contributor

mriddle commented Jul 11, 2014

Thanks for the fix 👍

@junkpot1212
Copy link

👍

sethvargo added a commit that referenced this pull request Jul 11, 2014
Follow redirects when we try to get a cookbook
@sethvargo sethvargo merged commit b342abe into berkshelf:master Jul 11, 2014
@jujugrrr jujugrrr deleted the jujugrrr-follow301 branch July 11, 2014 15:50
@leejones
Copy link

💖

@jujugrrr
Copy link
Contributor Author

@sethvargo Thanks for the merge! I'm not sure how many people are impacted by this issue. In our case it's a blocker for our CI/CD process. We are now using Git as a source for the Berkshelf Gem as 3.1.3 is failing.

Do you think this fix worth a Gem version bump?

Thank you

@sethvargo
Copy link
Contributor

@jujugrrr #1260

@sethvargo
Copy link
Contributor

We already backported to Berkshelf 2

@jujugrrr
Copy link
Contributor Author

@sethvargo Thanks!

@cstewart87 cstewart87 mentioned this pull request Jul 23, 2014
@berkshelf berkshelf locked and limited conversation to collaborators Jun 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants