Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 'verify' command to Berkshelf #1331

Merged
merged 1 commit into from
Oct 29, 2014
Merged

add 'verify' command to Berkshelf #1331

merged 1 commit into from
Oct 29, 2014

Conversation

reset
Copy link
Contributor

@reset reset commented Oct 28, 2014

This will perform a ruby syntax, erb syntax, and file name verification on all cookbooks installed by a given Berksfile.

Right now this only grabs the first error and displays it. We can collect all exceptions and output a digest at a later point.

/cc @sethvargo

this will perform a ruby syntax, erb syntax, and file name verification on
all cookbooks installed by a given Berksfile
@sethvargo
Copy link
Contributor

@reset Doesn't Ridley already do this? I feel like I have definitely seen code like this before...

@reset
Copy link
Contributor Author

reset commented Oct 28, 2014

It's doing it and we're leveraging it. It just does it at upload time and this allows you to define a step in your release process earlier.

The last thing you do when you release software following the environment cookbook pattern is to upload your cookbook. You could waste a lot of time just to find out the cookbook can't even "compile" ;).

Also much faster then loading a VM with Test Kitchen to identify a syntax problem.

Jamie Winsor
@resetexistence

On Oct 27, 2014, at 6:50 PM, Seth Vargo notifications@github.com wrote:

@reset Doesn't Ridley already do this? I feel like I have definitely seen code like this before...


Reply to this email directly or view it on GitHub.

@sethvargo
Copy link
Contributor

Lol fair. It looks like the build is failing though, but otherwise 👍

reset added a commit that referenced this pull request Oct 29, 2014
add 'verify' command to Berkshelf
@reset reset merged commit 5d9fae3 into master Oct 29, 2014
@reset reset deleted the verify branch October 29, 2014 19:03
@berkshelf berkshelf locked and limited conversation to collaborators Jun 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants