Resolver should error if incompatible dependencies are specified #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
@ivey it might be best to ignore recommends and suggests altogether. We're currently merging depends and recommends together. |
|
👍 |
|
Yeah I also thought about adding a "no recommends" or at least treating them separately - and not raising an error if they couldn't be satisfied. |
reset
added a commit
that referenced
this pull request
Mar 5, 2013
Resolver should error if incompatible dependencies are specified
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicit dependency on git, runit =1.0.6 and nginx =1.3.0. ngnix 1.3.0 has a dependency on runit "<= 0.16.2", git 2.3.0 has a dependency on runit "~> 1.0.0".
runit 1.0.2 was in the Berkshelf, and since the resolver found the requirement from git first, it used that one, installing 1.0.2.
Expected behavior would be to either use the higher precedence definition in metadata, or raise an error.
Side-note: some of these dependencies are coming from recommends, not depends, which makes this more complicated.