Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure path/scm location is used during dependency resolution #976

Merged
merged 2 commits into from
Jan 5, 2014

Conversation

grobie
Copy link
Contributor

@grobie grobie commented Jan 5, 2014

This fixes two problems when using path and SCM locations:

  1. Custom cookbook on given location uses different dependencies

    For example if someone uses a local/scm cookbook with the same name/version available in the community cookbook site, the dependencies of the community cookbook will be added to the resolution graph. This change stops to populate the dependency graph with any cookbook dependencies from global sources if a local cookbook is already present.

  2. Solve graph only using the demanded location cookbook version

    If a location is specified, the cookbook constraint should be locked to that version automatically.

Fixes #975.

grobie added 2 commits January 5, 2014 10:54
In case a custom location (SCM, path) is specified for a cookbook,
ignore the cookbook version from remote locations like Opscode or a Chef
server.

This is necessary in case a local (potentially development) version uses
different dependencies. The "missing dependency" specified in the
feature is only one possible error scenario, the graph solution can fail
also in other ways.
In case a cookbook is used from a custom location (SCM, path) this
change ensures that the graph gets solved for that exact version.
@reset
Copy link
Contributor

reset commented Jan 5, 2014

Looks proper to me, thanks @grobie

reset added a commit that referenced this pull request Jan 5, 2014
Make sure path/scm location is used during dependency resolution
@reset reset merged commit 9d12f89 into berkshelf:master Jan 5, 2014
@berkshelf berkshelf locked and limited conversation to collaborators Jun 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Path version is not a requirement
2 participants