Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add some benchmark testcases #154

Merged
merged 1 commit into from
Oct 4, 2024
Merged

test: add some benchmark testcases #154

merged 1 commit into from
Oct 4, 2024

Conversation

ai-chen2050
Copy link
Contributor

No description provided.

@ai-chen2050
test: add some benchmark testcases
e728b93 
Signed-off-by: ai-chen2050 <1033467071@qq.com>
@jefft0
Copy link
Collaborator

jefft0 commented Aug 23, 2024

On my macOS, make test passes. Need to get input from @D4ryl00 .

@jefft0
Copy link
Collaborator

jefft0 commented Sep 6, 2024

@D4ryl00 will take a look.

@jefft0 jefft0 requested a review from D4ryl00 September 6, 2024 12:06
@jefft0 jefft0 self-requested a review October 4, 2024 12:44
jefft0
jefft0 approved these changes Oct 4, 2024
View reviewed changes
Copy link
Collaborator

@jefft0 jefft0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go test -benchmem -run='^$' -bench '^BenchmarkKeyValueStore$' berty.tech/go-orbit-db/tests -v -count=1 -benchtime=1000x works.
Look good. Thanks for the PR!

@jefft0 jefft0 merged commit e78c3ee into berty:master Oct 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jefft0 jefft0 jefft0 approved these changes

@D4ryl00 D4ryl00 Awaiting requested review from D4ryl00

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ai-chen2050 @jefft0