POC API that avoids clone for consideration. #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like the underlying query implementation supports query without having to clone the input data, however the use of JsonPathFinder forces this to happen. Added a POC API for querying without cloning that introduces a new enum `JsonPtr` for holding values. The reason this has to exist is that deref on JsonPathValue is not possible.
|
Hi. Thanks for the PR. That is great, that you use the library. Sure, the change seems to be useful. let's bring it in |
|
Awesome. I've pushed some minor polish. Let me know if there's anything else you'd like to see. Of course if you have changes in mind that you'd like to make yourself then I'm also happy for you take it over the line. |
besok
approved these changes
Jul 22, 2023
|
Great. Thanks. That is a really helpful change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I came across this library a while back when I was looking at different jsonpath libraries and it looks nice. The only issue seemed to be that the
JsonPathFinderAPI seemed to require cloning to happen, which was a showstopper for my use case. Recently I had cause to look again as the other major jsonpath library for Rust looks abandoned and has bugs.It looks like the underlying query implementation for
jsonpath-rustsupports query without having to clone the input data, however the use ofJsonPathFinderforces this to happen.This PR is a POC API for querying without cloning that introduces a new enum
JsonPtrfor holding values. The reason this has to exist is thatderefonJsonPathValueis not possible without a panic forNoValue.It'd be great if this approach could be considered for this project.