Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup after 0.6.0 changes #66

Merged
merged 3 commits into from
Jun 11, 2024
Merged

Conversation

xMAC94x
Copy link
Contributor

@xMAC94x xMAC94x commented Jun 10, 2024

Thanks for the last PR merge.

I think there were some things missing, e.g. that I upaded the README to reflect the latest changes.
I tried to do that here.

All changes should be backwards compatible, so a 0.6.1 release would do it, however I leave the release decision (whether and if so, how) to you.

I applied all cargo clippy lints, and they are now also checked for the whole repo. ( if found now workaround other than ![allow(clippy::empty_docs)], because the doc comment comes from an imported crate, via the Parser macro :/ )

Note regarding the license. I modified the Cargo.toml to show MIT as that is what the license-file currently contains.
crates.io does not inspect the file itself, but just shows non-standard when license-file is used.

You might also consider to re-license your crate under dual MIT or Apache-2.0, e.g. like crates like https://github.com/dtolnay/syn do. Its what most rust projects (and rust Itself choose): https://www.rust-lang.org/policies/licenses

xMAC94x added 3 commits June 9, 2024 23:15
try to keep it simple, and link to docs as they are actually tested in CI via `cargo test`
@besok
Copy link
Owner

besok commented Jun 11, 2024

Thanks for the pr.

@besok besok merged commit 3eb0149 into besok:main Jun 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants