Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JsonLike trait #74

Merged
merged 6 commits into from
Oct 15, 2024
Merged

Add JsonLike trait #74

merged 6 commits into from
Oct 15, 2024

Conversation

paomian
Copy link
Contributor

@paomian paomian commented Oct 10, 2024

Make the json path function available to any type that implements JsonLike.

@paomian paomian mentioned this pull request Oct 12, 2024
Closed
besok
besok reviewed Oct 13, 2024
View reviewed changes
Copy link
Owner

@besok besok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great PR.
I left several mostly cosmetic comments.

src/parser/model.rs Outdated Show resolved Hide resolved
benches/equal.rs Outdated Show resolved Hide resolved
benches/regex.rs Outdated Show resolved Hide resolved
src/path/index.rs Outdated Show resolved Hide resolved
src/path/index.rs Outdated Show resolved Hide resolved
src/path/index.rs Outdated Show resolved Hide resolved
src/path/json.rs Outdated Show resolved Hide resolved
src/path/mod.rs Show resolved Hide resolved
src/path/mod.rs Show resolved Hide resolved
src/path/mod.rs Outdated Show resolved Hide resolved
@paomian
Copy link
Contributor Author

paomian commented Oct 15, 2024

Thanks for the review.
I'll do the change later, I've had some busy days.

@paomian paomian requested a review from besok October 15, 2024 06:46
@paomian paomian marked this pull request as ready for review October 15, 2024 06:48
@besok
Copy link
Owner

besok commented Oct 15, 2024

Great. Thanks for the update. I will update the version today.

@besok besok merged commit 5467b2d into besok:main Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@besok besok besok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paomian @besok