Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build steps so people can build this program themselves #9

Closed
wants to merge 2 commits into from

Conversation

adriaandotcom
Copy link

First of all, thanks for writing this code. I took the liberty to add some build steps to the project. Not sure if you're open to pull requests, but here it is.

I'm also updating the fork of this project to include a mute_mic command. I thought the mute command would mute the mic, but it muted the speakers (which makes sense). If you want, I can create a pull request for that command. I will use it to have a physical button that will mute me on Zoom calls.

@phillipsnick
Copy link

Nice one, never would have got this repo working without this :)

@ndbroadbent
Copy link

Thanks, this is really helpful! I got a bit stuck before I realized that I needed the .mod file as well

@bessarabov
Copy link
Owner

@adriaandotcom huge thank you for your work! You did the absolutely correct things here, but I didn't reviewed it and merged in time, so now I did nearly same things myself. As there are go.mod and go.sum files in the repo (and also some updated in README.md) I'm going to close this without merge.

Not sure if you're open to pull requests, but here it is.

:) As you can see I don't spend a lot of time supporting this project. I"m not closed to pull requests, but I cannot provide any guarantees that I will merge the proposed pull requests or that I will react to them quickly, or even react to them at all.

I'm also updating the fork of this project to include a mute_mic command. I thought the mute command would mute the mic, but it muted the speakers (which makes sense). If you want, I can create a pull request for that command. I will use it to have a physical button that will mute me on Zoom calls.

Yep, I'm also using some physical button to control my macbook (this was the idea of this tiny project). I want to close this PR, but I really like you idea about mute_mic — so I'm creating a new issue about it #20 (but please don't expect it to be solved quickly or even at all)

@bessarabov bessarabov closed this Mar 10, 2024
@adriaandotcom
Copy link
Author

No problem, thanks for explaining. It's open source, so no expectations!

Regarding the mute_mic PR, I don't use the lib anymore, but loved playing with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants