Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed some window opening #456

Merged
merged 1 commit into from
Jul 20, 2020
Merged

Fixed some window opening #456

merged 1 commit into from
Jul 20, 2020

Conversation

asizon
Copy link
Member

@asizon asizon commented Jul 18, 2020

Seems that we need this to work with export video feature when we go to the save file step, as comented here: #450 (comment)

@sonarcloud
Copy link

sonarcloud bot commented Jul 18, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@asizon
Copy link
Member Author

asizon commented Jul 18, 2020

Now works as expected:

image

@asizon asizon mentioned this pull request Jul 18, 2020
Merged
McGiverGim
McGiverGim approved these changes Jul 18, 2020
View reviewed changes
Copy link
Member

@McGiverGim McGiverGim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange, it works for all windows but I didn't test the export feature. Good catch!

@mikeller mikeller added this to the 3.6.0 milestone Jul 19, 2020
@mikeller mikeller merged commit 05bc9e5 into betaflight:master Jul 20, 2020
@McGiverGim McGiverGim mentioned this pull request Jul 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McGiverGim McGiverGim McGiverGim approved these changes

Assignees
No one assigned
Labels
RN: BUGFIX
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@asizon @McGiverGim @mikeller