Removed Dterm Rpm and Vbat Pid Compensation header options from 4.3 #459
Conversation
js/header_dialog.js
Outdated
| @@ -28,6 +28,7 @@ function HeaderDialog(dialog, onSave) { | |||
| {name:'airmode_activate_throttle' , type:FIRMWARE_TYPE_BETAFLIGHT, min:'2.8.0', max:'999.9.9'}, | |||
| {name:'rollPitchItermIgnoreRate' , type:FIRMWARE_TYPE_BETAFLIGHT, min:'2.8.0', max:'3.0.1'}, | |||
| {name:'yawItermIgnoreRate' , type:FIRMWARE_TYPE_BETAFLIGHT, min:'2.8.0', max:'3.0.1'}, | |||
| {name:'vbat_pid_compensation' , type:FIRMWARE_TYPE_BETAFLIGHT, min:'2.8.0', max:'4.2.0'}, | |||
There was a problem hiding this comment.
imho it should be 4.2.9 - to include maintenance releases as well
There was a problem hiding this comment.
Sure @thelsotopes , thanks!
There was a problem hiding this comment.
Good point. Or even 4.2.999 to follow the pattern that is used.
There was a problem hiding this comment.
bad idea ... the pattern is 999.9.9 not 999.9.999
There was a problem hiding this comment.
yes, 999 is used only for the first number, done!
There was a problem hiding this comment.
This is broken now - it will fail for 4.2.10 and following. Please learn how to use SemVer.
There was a problem hiding this comment.
Yes right @mikeller, then im going to use 999 like you suggested
js/header_dialog.js
Outdated
| {name:'dterm_rpm_notch_min' , type:FIRMWARE_TYPE_BETAFLIGHT, min:'4.1.0', max:'999.9.9'}, | ||
| {name:'dterm_rpm_notch_harmonics' , type:FIRMWARE_TYPE_BETAFLIGHT, min:'4.1.0', max:'4.2.0'}, | ||
| {name:'dterm_rpm_notch_q' , type:FIRMWARE_TYPE_BETAFLIGHT, min:'4.1.0', max:'4.2.0'}, | ||
| {name:'dterm_rpm_notch_min' , type:FIRMWARE_TYPE_BETAFLIGHT, min:'4.1.0', max:'4.2.0'}, |
There was a problem hiding this comment.
the same for these three
|
Kudos, SonarCloud Quality Gate passed!
|
To go with betaflight/betaflight#9633 and betaflight/betaflight#9984