Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated NW.js to 0.54.0, and updated libraries to match. #518

Merged
merged 1 commit into from
Aug 31, 2021

Conversation

mikeller
Copy link
Member

@mikeller mikeller commented Jun 9, 2021

Tested video playback successfully in Linux and Windows.
For MacOS there now is an -arm64 version of the FFMPEG library, so I suspect video playback will not work right now for M1 Macs, but it will need some testing to figure out how to determine the CPU architecture on Mac, and then coding for it.

@sonarcloud
Copy link

sonarcloud bot commented Jun 13, 2021

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
3.4% 3.4% Duplication

@McGiverGim
Copy link
Member

I suppose the title of the PR is wrong?

@blckmn
Copy link
Member

blckmn commented Aug 31, 2021

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

@mikeller mikeller changed the title Updated ubuntu version used in Azure build to 20.04. Updated NW.js to 0.54.0, and updated libraries to match. Aug 31, 2021
@mikeller mikeller merged commit 9ae0962 into betaflight:master Aug 31, 2021
@mikeller mikeller deleted the update_nw_js_to_0_54_0 branch August 31, 2021 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants