Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.3 field support #539

Merged
merged 5 commits into from
Nov 25, 2021
Merged

4.3 field support #539

merged 5 commits into from
Nov 25, 2021

Conversation

ctzsnooze
Copy link
Member

@ctzsnooze ctzsnooze commented Oct 27, 2021

Provides full support for all the new field names in 4.3 in the Log Header information screen.

Includes the changes from #535 and #521, which I will close now, as well as supporting the changes made in betaflight PR's 10978 lowpass field names and 10856 rpm filter names and others.

Fixes an issue with incorrect RPM readings in the Dynamic Idle debug, which were 4 times lower than they should have been.

Tested and ready to merge.

Very useful for anyone working with 4.3 logs after all the changes we've made.

Extensive re-arrangement of fields and CSS changes as well. The most useful tuning fields are at the top. Fields are entered, and the scrolling widgets are removed.

Screenshot:

Screen Shot 2021-10-31 at 18 12 57

@ctzsnooze
Copy link
Member Author

Updated to be fully compatible with #11061

Checked and ready to merge.

@blckmn
Copy link
Member

blckmn commented Nov 15, 2021

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> FAIL
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> FAIL
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> PASS
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

@sonarcloud
Copy link

sonarcloud bot commented Nov 25, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 17 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 12 Code Smells

No Coverage information No Coverage information
1.2% 1.2% Duplication

@blckmn blckmn merged commit 5ac20d7 into betaflight:master Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants